Matthew Dorner
Matthew Dorner
I can take this if it's available.
> The function signature should look like: > > ```go > func UserHasBeenDeactivated(userID string, permanentDelete bool) > ``` > @mickmister It would be easier on the server side if we...
If a plugin really does need to know the difference between a user being deactivated and deleted, imo these could be two separate hooks instead. For the purposes here, it...
@mickmister Since this issue was created due to the case where user is made inactive via LDAP sync, I want to make sure my solution works for that. But I...
> What is the side effect of "not handling the case where the token is both expired and revoked"? Note that the plugin's API is called multiple times when the...
> Also, we will want to make sure the changes in this PR work with the changes from https://github.com/mattermost/mattermost-plugin-gitlab/pull/298 Yeah, I waited for that PR to be merged and this...
@mickmister In `checkAndRefreshToken`, we just check the expiration time of the token from the KV store to determine if it needs to be refreshed. If a token is invalid, we...
> Are we getting the "invalid token" error from GitLab in this case? Shouldn't we just delete it from our database and tell the user about it like usual? @mickmister...
@mickmister yes, that is one of the solutions that occurred to me. Basically, check for both conditions (expired and revoked) in the same place. I didn't want to go that...