Matt Cochrane
Matt Cochrane
Is there any reason these changes haven't been merged? What needs to be fixed still? Just modifying the code to use `DictionaryList!Cookie` instead of `CookieStore`?
I started a spreadsheet for comparing the different responses. I'll keep working on it when I get some more time. https://docs.google.com/spreadsheets/d/1jMkXpAGmKcGR0Dm9fQNYv85lunIuVjDUGE2qcB_J2hE/edit?usp=sharing I've done most of the ticker responses so far...
Had a crack at implementing some of this. Let me know what you think of this approach. Added a folder called `formatters` under `interface`: ``` + bitex - api +...
Yep, I'll pull your unit test and make some modifications to get it to pass.
Just having a look at your unit test, a couple of things: 1. not so important but perhaps `InterfaceResponse` is a better name than `APIResponse` as it works with the...
@bebosudo Thanks for the feedback! 1. Ok great, I'll `replace` float with `decimal` 2. Thanks. That makes sense. Will update. Is it worth having the runtime check do you think?...
Hi @bebosudo Good work. Some great ideas in there. I like the idea of the parameterised decorator ```python @format_with(BitfinexFormattedResponse) ``` as opposed to my 'magic' approach to choosing a formatter....
@bebosudo sounds good, lets listen for @nlsdfnbch 's input :) And merry (belated) xmas to both of you, hope you have a good holiday!
Cool. Fair enough if you prefer the `@format_with(FormatterClass)` approach over `@format_response` for the decorator. I mean there's not a huge difference, it's a trade off between being easy to understand...
I was just thinking about mocked API tests vs live API tests and the difference between them (and which is more appropriate)... Having a static 'example' that the tests are...