MattAgn

Results 31 comments of MattAgn

Wow so quick @mdjastrzebski 😮

@mdjastrzebski thanks a lot for the quick review! I'm far from done though, the work I still have to do: - add the a11y check in all queries - add...

> I like to have an API as close as possible from rtl web, so using `hidden` sounds like a great solution. Since their API lets user should the default...

@mdjastrzebski I agree that respectAccessibility was not so clear either, especially since we also check styles, maybe we should split it into 2 options `respectA11yVisbility` & `respectStylingVisibility`? A possible way...

@mdjastrzebski oh alright I understand!

@mdjastrzebski I found 2 different ways to handle the a11y option and I can't choose between the 2: 1. Handle the option in each query independently, tried in [this commit](https://github.com/callstack/react-native-testing-library/pull/1064/commits/59a143f7d60621a2db484674a09df9beb1739520)....

@mdjastrzebski I was away for a while, i'm ready to start working back on this 🚀 thanks for the isInaccessible function! Indeed should make it easier :)

> @MattAgn not sure but your first example looks a bit too complex. Seems like you could just declare some common `findAll` function: > > ``` > function findAll(instance: ReactTestInstance,...

> @MattAgn great to read that you're back! > > re `findAll`: let's start with simplest implementation as in DTL: > > ```ts > root.findAll(...).filter(element => { > return hidden...

> ```ts > cachedIsSubtreeInaccessible > ``` sure, always nice to have a little boost in performance. I would still be in favor of extracting the findAll function though, wdyt? Otherwise...