Matilda-Clerke

Results 13 comments of Matilda-Clerke

This might be a bit redundant after my refactoring work is in place. See https://www.notion.so/consensys/EthTask-and-EthPeer-system-ba1f00f85f5e4b9c94a0dd9c661f2c5c?d=d8303d044a8d40e590b48ea29885e154#567a120382c544a9b6e9431a3c951926 and https://github.com/hyperledger/besu/pull/7602

@fab-10 I haven't included any feedback regarding peer performance or quality in the refactor yet, so it should be possible to ensure we provide feedback for empty responses too. I'll...

@macfarla Looks like this change from @pinges would have fixed this exception: [2cf61d662137a7489e560ce733fc4080d062ddba](https://github.com/hyperledger/besu/commit/2cf61d662137a7489e560ce733fc4080d062ddba) Should be ok to close this now?

example documentation: https://besu.hyperledger.org/public-networks/how-to/bonsai-limit-trie-logs

besu-docs PR: https://github.com/hyperledger/besu-docs/pull/1815

I actually couldn't find this in the spec. EIP-4444 explicitly places it out of scope, and I wasn't able to find any other relevant EIPs to cover it. As such,...

Here's one example where a null response should be used when block data is missing: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getblockbyhash

Ok, those last 3 commits aim for improve hive tests. I've now taken care of all of the `getBlock` tests expecting null results, but this has caused some additional failures...

Seems geth is returning a 4444 error code when a block is not present due to pruning. In order to achieve this, I'm afraid we'd need to refactor as described....

As discussed this morning: Decided to revert changes related to hive tests and just fix the initial exceptions being thrown