Matan Borenkraout
Matan Borenkraout
@stefee it looks like the reproduction link isn't working, any chance you can have a look please? @incompl do you have a cloneable reproduction so we'll be able to investigate?
I hope I'm getting this correctly but IMO the problem here is these two lines: ``` // Loader should appear const loader = await screen.findByText("Loading"); // Loader should disappear once...
Thanks for taking care of that @cwonrails, didn't get the time for that. Regarding the warn vs error, Dan Abramov stated in one of his comments he doesn't believe this...
@jahed I believe that even though exhaustive-deps is more of a helper than a rule, the benefit of it is worth the work, as this will affect react devs only....
@orpheus definitely right, my bad. Actually made a PR just have to fix something there.
@jahed I saw that you opened a new PR so I closed mine.. Sorry about the `node_modules` 🤦🏼♂️ My bad.
Just to be sure, I'm not 100% confident that in the browser it's working as it should. When calling `document.getElementById("focus_input").focus();` from the console, the design doesn't really change for me,...
@ph-fritsche great initiative, I highly agree with all of the points. Small thing about 3, I agree that the differences between JSDOM and Chrome are enormous (don't forget about happy-dom...
Hi @kcs-udayarajangauthaman. I'm sorry but this issue doesn't follow our template and it's really hard for us to understand what's the specific issue you're raising here. A reproducible codesandbox will...
@nickmccurdy I saw this one: https://github.com/testing-library/react-testing-library/issues/837 I think it might be because this wasn't implemented in dom-testing-library but I might get it wrong.. do you think it's related?