Ma Shimiao

Results 26 comments of Ma Shimiao

ping @opencontainers/runtime-spec-maintainers

@opencontainers/runtime-spec-maintainers PTAL

@opencontainers/runtime-spec-maintainers PTAL

I have made some milestones on Github based on this PR.

let's keep it open for more milestone discussions

I have moved them into common util package in #344

From the code, part of them uses Config directly, part of them still use set/add function(which needs loop logic or value checks). I can't deny currently most of set/add functions...

On 11/08/2016 03:32 PM, W. Trevor King wrote: > everything the caller asked without much validation, and leave it to > them to call ‘oci-runtime-tool validate …’ when they feel...

On 05/11/2017 01:19 PM, W. Trevor King wrote: > ‘generate’ is not about spec compliance (that's ‘validate’), it's > about creating a useful starting point for users. Agree. But I...

In my own opinion, `generate` should output config info based on what runtime-spec minimally request in default. Any optional or additional fields in config should be specified by users which...