Marshalzxy

Results 10 comments of Marshalzxy

runtime: fix vmcache for qemu vm

@[egernst](https://github.com/egernst) @[bergwolf](https://github.com/bergwolf) Could you please review this patch？

runtime: fix vmcache for qemu vm

@tiezhuoyu Have you added CI job for vmcache？

Why Runc do bind mount config.rootfs to config.rootfs while it create container ?

> I am not quite sure but _maybe_ this mount is not needed if `config.Rootfs` is already a mount point. > > If the above is true, we can make...

Why Runc do bind mount config.rootfs to config.rootfs while it create container ?

> > i think maybe we can do some optimize this step. > > This is what the above patch does. I am not convinced though whether we should have...

Why Runc do bind mount config.rootfs to config.rootfs while it create container ?

> > It's indeed more complicated. At lease we should add some comments above > > return mount(config.Rootfs, config.Rootfs, "", "bind", unix.MS_BIND|unix.MS_REC, "") > > To explaint under some circumstances...

let all containers in the same shimV2 use the same ttrpc client

> I think it should be one tttrpc connection to one shimv2 proccess , no matter there so many containers under the same shimv2 proccess Great！

count: n instruction not enforced

count still has no effect. Even I delete count field in required_instructions，the rule file still works. I test in version 0.3.3.

fix docker inspect doesn't contain init field if set init=true at daemon.json

> To be clear; I'm not strictly _against_ changes for this., and I agree that it's not very intuitive that this option is not shown in `inspect`, but we should...

[Tinygo package] Support networking Socket

@alabulei1 Can https://github.com/alphahorizonio/tinynet solve you problems?

docker-proxy cannot exit after send SIGINT

Why libnetwork use os.Interrupt signal try to kill docker-proxy? Is there any special purpose?