Mark Berry

Results 33 comments of Mark Berry

I recently wrote `@storybook/testing-angular` that provides a method to compose a Story with the story, default export Meta, and global Meta as a single StoryFn. Instead of returning a component...

I need to go through the StoryStore changes to figure out how the fix may need to be done, because I haven't caught myself up on that change yet. I...

From what I have noticed @ThibaudAV is right. It doesn't seem to be preventing Storybook from working. I did notice this a few weeks ago at least, but I noticed...

It could be argued that this situation is more complicated than what a story should be doing anyway, but the one knob I had trouble converting to controls was a...

Should be fixed by #12382. I patched my node_modules to set the props in `NgZone`, similar to how I did in that PR and couldn't reproduce the issue any more....

@shilman Is this not something that should be handled by the docs addon? The ArgTypes is information that is useful for more than just Controls. One example is that filtering...

I have been thinking about this and my main hesitation is adding custom implementations for directives, because if the functionality isn't exactly the same or someone has another directive/component that...

@spaceribs As far as how they would be defined, something like that is what I was thinking. The blocker that I am thinking we would need, unless we dynamically create...

@ndelangen Yes. There is no way to identify a property in `props` as a directive. There is a chance the requested syntax would currently work, but the directive would most...

My assumption is that this means using Angular FormControls as args. Sort of like the POC I did a while ago, https://github.com/storybookjs/storybook/issues/12308#issuecomment-683956199. I was waiting for custom controls support before...