Haoyue Dai

the same issue

@cogito233 Thanks for reporting this! The results of `X;Z` is reasonable, on both `UInd` and `CInd with cond=const`. However, the results of `X;Y` on `UInd` is weird (though reasonable on`CInd...

up 话说为什么不用disqus/isso匿名呀 > @keithnull > 如果想要匿名参与讨论，可以注册 Github 小号。 > > 理论上，注册 Github 只需要邮箱即可，所以不必担心隐私风险🔒

Thanks for reaching out. Could you please tell us your causal-learn version and the minimum code snippet that reproduces your issue? Since `G, edges = fci(data, 'kci', 0.05, verbose=False)` should...

Yep. kci is basically in O(n^3) time complexity, with n being the sample size. The good thing is that kci is nonparametric, while fisherz only works for joint Gaussian.

@tofuwen Oh thanks for reminding! Will do it later tomorrow.

@zhi-yi-huang Seems that this pr contains changes of the following aspects (correct me if I have misunderstandings): 1. Fixed FCI and Fas bugs in `FCI.py` and `Fas.py` (of which the...

Hi @zhi-yi-huang Thanks for your efforts! Could you please commit your changes (e.g., [`GeneralGraph.py`](https://github.com/cmu-phil/causal-learn/blob/3cfd99ed132ef671654df7ed2b1806aca469da6e/causallearn/graph/GeneralGraph.py), [`TestGeneralGraph.py`](https://github.com/zhi-yi-huang/causal-learn/blob/pc_with_new_generalgraph/tests/TestGeneralGraph.py)) in your repo to this pull request? Then I'll review it before it's finally merged....

H @kunwuz! @zhi-yi-huang identified some flaws in the original `GeneralGraph` class, which led to the issue in #82. Now @zhi-yi-huang has fixed them in `GeneralGraph`, and is regenerating all the...

Hi @zhi-yi-huang Awesome! I just reviewed this pr and it is good to me. As an additional check, all modifications on the benchmark CPDAG results are in the form `-1...