Mark Hamstra

Results 296 comments of Mark Hamstra

What is actually broken in 2.3?

Figured I'd go through the source to see if I could spot anything that might be broken for 2.3. https://github.com/roryg/ElementHelper/blob/master/core/components/elementhelper/elements/plugins/plugin.elementhelper.php#L10 and https://github.com/roryg/ElementHelper/blob/master/core/components/elementhelper/elements/plugins/plugin.elementhelper.php#L297 `$modx->getMicroTime()` has been deprecated for a long time...

Perhaps the media source isn't built prior to the chunk?

It only includes keys that are not set to the default value, that's probably what you're seeing.

[aside]I wouldn't recommend using a package prefix like that...[/aside] When Gitify calls $modx->addPackage it doesn't currently have a way to know if you used a different prefix. That'll probably need...

Maybe with one-to-(one/many) relations we could skip adding extra directories and files, instead adding it right in to the main object.. like the example with the package/versions, that could in...

And with plugin events (#14) that would be like.. ``` data: packages: class: modPlugin primary: name relations: events: class: modPluginEvent alias: Events ``` ``` name: MyPlugin description: best one ever...

I think that makes complete sense and would be great improvement to get into 1.0.

Have you tried narrowing it down to a particular snippet that is failing to parse? Could it be, as the error suggests, an invalid file? There's nothing about PHP in...

Rough start is in the `issue-81` branch but modx:install doesn't quite seem to work now