Marco Munizaga

Results 300 comments of Marco Munizaga

Looks like it's an Android issue: https://issuetracker.google.com/issues/146458518

We already started smoke testing the 0.21 release and wanted to make that release with minimal changes. But the 0.22 release will be right around the corner :)

Re openeing since I think there are some fixes still left to do

Also see some flakiness here: https://app.circleci.com/pipelines/github/libp2p/go-libp2p/34/workflows/aabd41b3-1759-405e-be53-b9da9703c1f2/jobs/111?invite=true#step-112-937 Which happens here: https://github.com/libp2p/go-libp2p/blob/master/p2p/protocol/identify/id_test.go#L832 That bit seems very prone to timing flakiness since the only difference between the two assertions is a sleep of...

It seems to me that a transport should encapsulate all the logic around (at least a part of) the multiaddr. It seems weird that the host knows how to resolve...

> As for caching, isn't the OS doing this already? Have we seen a need to handle this caching ourselves? Ah we support custom dns resolvers. Okay I agree the...

Yep! stream migration would help in the race edge case where both peers open up connections at roughly the same time. And it has the added benefit of not needing...

I think we can still be very deliberate with changes to the core interfaces even if it's in a single repo. I'm not aware of many libraries that have their...

Dialing wss is now supported (https://github.com/libp2p/go-ws-transport/pull/115). So this should work if you use the websocket transport

> Looks like this introduced some new flakiness, but I can't figure out why: > > ``` > === RUN TestBasicDialSync > dial_sync_test.go:74: > Error Trace: dial_sync_test.go:74 > Error: Condition...