Marcell Perger

Results 6 comments of Marcell Perger

Perhaps N characters of change might be a better metric as if there are several small typo fixes that change a few characters on each line, that could show up...

> Unless I can get the workaround working I won't merge it into my release branches, so for now most of my MacOS builds are still failing. but I now...

### Here is what I think is happening: Windows uses [UTF-16 encoding for Unicode](https://learn.microsoft.com/en-us/windows/win32/intl/unicode#:~:text=Unicode%2Denabled%20functions%20are%20described%20in%20Conventions%20for%20Function%20Prototypes.%20These%20functions%20use%20UTF%2D16%20(wide%20character)%20encoding). So in `src_c/scrap_win.c`: https://github.com/pygame/pygame/blob/8d929587ec246e214408763e778ec2a1813c9ff7/src_c/scrap_win.c#L274 `GetClipboardData` will give utf-16 (not utf-8) data. It seems that this data...

I don't really understand why this could cause problems. We're already setting `localPrefix` from the CLI arguments in the same way so surely doing the same with the environment variable...

> This is a _danger area_ and we should make sure we know if this was intentional before adding it. IMHO, this wasn't intentional and it was simply forgotten about...

> It's also not clear what it should include. The whole loop/condition is too lengthy for the breadcrumb. Maybe it could show the condition if it's less than a certain...