Marius Hanl
Marius Hanl
I got this problem as well today. NPE as `runs` is null in line `359`. Does it make sense to first 'resolve' this by adding a simple null check and...
I had a look at the PR. But it took quite a while to fully understand the changes (also the current implementation 😄). I think it make sense to improve...
> Same goes for the selection model; if set to `null` it should not allow any kind of selection, which again seems best achieved by installing a model that ignores...
> ``` > public final MultipleSelectionModel getSelectionModel() { > return selectionModel == null ? null : > selectionModel.get() == NONE_SELECTION_MODEL ? null : selectionModel.get(); > } > ``` That would...
> The question is whether or not `null` should be a valid value for the `selectionModel` and `focusModel` properties. I think there are good reasons to think that it shouldn't....
/issue add JDK-8230098
/issue remove JDK-8230098
> As I mentioned in that JBS issue, I tend to agree that if we were starting today with a blank sheet of paper, we might have disallowed null and...
> ListViewSkin:381 calls getSelectionModel() probably, same to focusModel here.
> There is a condition observed while debugging [JDK-8187145](https://bugs.openjdk.org/browse/JDK-8187145), when a non-null selection model is set, the user creates a non-empty selection, then the selection is set to null. >...