Manav Aggarwal

Results 59 issues of Manav Aggarwal

The node.md doc [here](https://github.com/cosmos/iavl/blob/master/docs/node/node.md) says “Inner nodes have keys equal to the highest key on their left branch and have values set to nil.” The mutable_tree.md doc [here](https://github.com/cosmos/iavl/blob/master/docs/tree/mutable_tree.md) has a...

https://github.com/cosmos/ics23/blob/f4deb054b697458e7f0aa353c2f45a365361e895/go/ops.go#L62 throws an error for both when value is nil and when value is an empty array. In my opinion, having an empty array should be okay but currently, it...

- [x] https://github.com/rollkit/rollkit/issues/829 - [x] #1724 - [x] Refactor sequencer like an endpoint so that it can: - Accept a Tx - create a batch post to DA - pull/subscribe...

T:Epic
C: sequencing
T:performance

That means if I sync and I am far behind, I would be able to sync fully no matter the height difference. I think we should test how the sync...

C:p2p
T:testing
va

This epic should roughly follow the steps in [ADR](https://github.com/rollkit/rollkit/blob/main/specs/lazy-adr/adr-009-state-fraud-proofs.md). The design in this ADR requires adaptation to be compatible with ABCI++ design first. After that's done, the following steps need...

C:state-fraud-proofs
epic
blocked

For some reason, setting genesis doc initial height to 1 for light nodes is needed to make them sync properly. We should investigate why that needs to be done. See...

C:light-client
v1

Need to change the below method across the DA interfaces and implementations: ```go SubmitBlocks(ctx context.Context, blocks []*types.Block) ``` to have this signature: ```go SubmitBlobs(ctx context.Context, blobs []*blob.Blob) ``` Currently, the...

C:data-availability
v1

A `doneBuildingBlockCh` can be used to notify multiple subscribers when a block has been built. It's intended to help improve the UX of lightclient frontends and wallets. Was removed in:...

C:light-client
blocked

The [gm repo](https://github.com/rollkit/gm) Dockerfiles should be reflected to handle the latest version. The [guide to restarting a rollup node](https://rollkit.dev/tutorials/restart-rollup) should be incorporated in the Dockerfile to cover https://github.com/rollkit/rollkit/issues/900.

T:dev-usability-and-ux
P:high
docker
v1

The Block Cache is not needed for heights smaller than the current height and the hashes of the blocks for these heights should be discarded. Can be implemented as a...

T:code-hygiene