Mischa Krüger

Results 157 comments of Mischa Krüger

Is there a possibility to cache language-check and necessary data?

It's a general problem to combine patches and help text from linters as they don't provide both. It's possible to run the linter twice (very bad for performance), and relating...

That looks good, so in principle we use step-by-step pattern matching to assign to the parsed ast elements of pygments our `SourceRange` and other classes. I'm fine with that :)

If I recall correctly, PEP8 allows an "issue-format" that provides more detailed messages. But then we don't have patches. Best would be to have patches and issues combined.

> We would have to rather fix this for all bears that have code correcting capabilities. I bumped into another similar issue, see #502 PEP8Bear is an exception as it...

@rammanoj this is just a sample. What's important is that the bear doesn't seem to work according to @ishanSrt , so that needs investigation and confirmation.

As soon as the PR is in ready-to-merge state, remove the `WIP:` in the title @rubdos so it appears in our pending-review list :)

ah sorry... though for specific issues rather ping us on gitter ;) The checkstyle bug should have been fixed I believe. Try to rebase to master, if it still fails...

and about travis: no idea, try to restart the build via the rebase. If it still persists we need to look at it closer^^

1. What about the temp-commit? ;) 2. I would expect in the commit for AddNewlineAction to just do stuff with this action only, not mixing with EditCommitMessageAction. Please properly separate...