Mahati Chamarthy
Mahati Chamarthy
@eddyashton @jumaffre So the daily passed with this change. Is it reasonable to assume this as an indicator to merge or am I missing something else?
@eddyashton I agree, and until there's a way for `lts_compatibility` test to run safely, it looks like the OpenAPI schema changes for `/app` will have to revert. I will push...
Revisit: - [ ] Explore if we need certificate endorsements for Executors - [ ] Explore if we need to use attested TLS
@achamayou When `test_historical_receipts_with_claims` test in `e2e_logging.py` is enabled (#4370), and I manually modify logging.js to pass a non-SHA256 as input for `set_claims_digest`, it does trigger the exception.
I tested this in a hacky way using logging in cpp code and a small test in python infra that submits this new proposal. It does reflect the new values...
@achamayou Now that we have JS runtime memory limit exposed which could avoid the node crashing, does it still make sense to have the historical queries cache size exposed as...
@achamayou Yes, an end to end test will complete this -- that's already being tracked here https://github.com/microsoft/CCF/issues/4799. So I'm closing this.