Matilda Horger

Results 69 comments of Matilda Horger

I'm working on a fix for this, and I'm struggling to understand the rationale and intentions behind [the post-adjustment code](https://github.com/campadrenalin/raphael/blob/master/raphael.svg.js#L591). ``` dif = a.y - (bb.y + bb.height / 2);...

That's pretty much what I was expecting. This is the sort of thing where sometimes it works out of the box as a nice surprise, but usually it breaks a...

I would think that the correct course of action is using the Address class in identities. You'll need some code to convert lists into Addresses, but due to their namedtuple...

I have a few other things I'm going to do first, but if this isn't ready to go in like a week, I will snipe it. I really want to...

Gonna go back on part of my above statement. There is a _lot_ of work that still needs to be done debugging this change, and it will incur a lot...

Ooh, hold off, hold off! Before making any changes, you should know that I am not currently developing EJTP-lib-python anymore. I'm happy to take improvements, if anyone else is using...

I'm inclined to agree. This seems like a perfect fit for named tuples, if it's supported in all our Python versions. If not, we can just go manual. We also...

Looks like the JSON module is compatible with namedtuples, but not arbitrary iterables. And namedtuples can be subclassed if we want anything special. All of which is supported in Python...

Bounty is $50. http://www.freedomsponsors.org/core/issue/275/make-addresses-a-class-instead-of-a-list --- _(Copied from acceptance criteria)_ Create a namedtuple subclass for EJTP addresses, overriding the __init__ function such that passing in a single string as an argument...

Indeed. While I'd like to focus on Frames _first_, I think _both_ would benefit from this kind of overhaul.