Wenrui Jiang

Results 49 comments of Wenrui Jiang

Something we can try is this: we can temporarily replace the nans with coordinates that is far from the earth surface when creating the tree. I am not sure if...

Simply mask the nans when creating the tree solved this issue. I have made some minor changes to the create_tree function in _oceandatset.py file. It has passed all the existing...

I haven't made the pull request yet. I actually forgot to back up the code, and it is deleted by sciserver. But fortunately, it's a really small change and I...

@ThomasHaine, I can make a cutout dataset and modify existing tests of functions that use the tree (say subsample.mooring). However, in order to merge those tests, I need to upload...

The survey station is also broken by changes in xgcm, with a similar message.

I don't think we should change anything here, although it apparently breaks a lot of things. Oceanspy is only trying to do the most basic things xgcm promises, interpolate velocity...

I am having a bit of a hard time finding this issue. I am using newer version of xarray to cutout LLC datasets now. It seems fine to me

I tried a similar thing here: ![image](https://user-images.githubusercontent.com/52629492/197357783-466b95d4-06bb-4056-ad17-2528c4146336.png) It seems fine to me...

My understanding of this issue is that, this is a problem with the test rather than anything wrong with the code. The test is doing the following things: 1. calculate...

the test is already assert_almost_equal, I suggest we don't change anything. It might be nice if we can refer to this issue in the comment. Change ``` # TODO: not...