Maarten Staa

Results 10 comments of Maarten Staa

![Screenshot 2021-06-11 at 15 39 38](https://user-images.githubusercontent.com/2743160/121695406-50574300-cacb-11eb-88b0-0cbb1b76bc40.png) Same here, also on macOS 11.4. *Edit*: Just realized there's a version 2 available (that doesn't show up as an auto-update), and that this...

Another example that I ran into when evaluating `prettier-php`: [playground link](https://loilo.github.io/prettier-php-playground/#N4IgDgTgpgLjCWUIHkwIPYDsDOIBcok8mMA6vACYwAW+AHAAwA0IMAhgEblW14AsLAK7YoAFU648AMzYAbES2zEA5rKgBFQehhR8M+VBZhqYAGpIlWfCADsAOj4gWMCG3iyVAYXQBbH2wAFAAkA-BdBQxAOVwBjKABlGABPNWswbAgAWgAmJxBoAEdBeGgA12V-PTkFEGIRCBgytgq2KoMAXxYoCngYdBQ0eCxJUDZsGDaRTtrMMEEJvBAAHgB+YzAAHUwtzDYfKGwwNjiAAgBBME2NgDlteCl4GLYMHABuLa3hKHPLjY2AWXQFCg8j+AFF-O53ttMDFZGNsCcAgiAO79CgAJQOsAAYv0AKq7GIIABuz26ZxiMXQghItwQDyeLxOUAAHjpMBREfFfFAAEJjKD0+6PZ5DGHALbtLYgdpAA) This results in the following PSR12 violation: ``` [exec] FILE: app/Notifications/PasswordResetForUnactivatedAccountNotification.php [exec] ----------------------------------------------------------------------------------------------------------- [exec] FOUND 1 ERROR AFFECTING 1...

> I'd say we could slowly promote the current `3.1.0` release to stable, would you agree? @MaartenStaa @cseufert Yes, agreed. Would probably be good to fix #968 first, but things...

@renanmav @n1ru4l @kastermester I've pushed two more commits. The typename in the output is now also a union when using interfaces, and I've fixed several edge cases when using fragments...

Yes, completely agree! It's important that the output is correct. As far as I can tell it is, but I'm relatively new to Relay (and was just immediately annoyed with...

Looking at the examples above, I guess it only knows what to do with "English", and not "English (US)" or "English (UK)" (or the respective language codes).

> ``` > ERROR: C:/users/XXX/desktop/XXX/projects/support/icon-converter/BUILD.bazel:5:22: Running lifecycle hooks on npm package [email protected] failed: (Exit 1): lifecycle-hooks.bat failed: error executing command bazel-out\x64_windows-opt\bin\external\aspect_rules_js\npm\private\lifecycle\lifecycle-hooks.bat source-map ../../../external/npm_icon_converter__source-map__0.6.1/package ... (remaining 1 argument skipped) > '""'...

Not currently, no. Is there any particular reason you can't wrap all `Route::group` calls in a single `Route::cache`?

You could wrap the entire file in a `Route::cache` call, like this: ```php Route::cache(__FILE__, function() { // Landing page Route::get('/', 'IndexController@getIndex'); Route::get('/about/us/', 'IndexController@aboutus'); Route::get('/for/teacher/', 'IndexController@forteacher'); Route::get('/for/student/', 'IndexController@forstudent'); // Teacher group...

Yeah, jump to definition (and most LSP things) don't work very well when there are parse errors. The LSP gets the new text of the source file, and tries to...