REGEARD Maxime comments

Results 21 comments of


                                            REGEARD Maxime

Fermi 2nd and 3rd Pulsar Catalog

> @MRegeard , is it ready to be reviewed or some work is still needed to add later on the 3PC? @bkhelifi, No some work is still needed here...

Fermi 2nd and 3rd Pulsar Catalog

I think that I made most of the implementations here. We still miss the light curve implementation, that is pending issue #4782.

Fermi 2nd and 3rd Pulsar Catalog

I will split this big PR into small pieces.

Fermi pulsar catalogs base class

> Thanks for the effort @MRegeard. Do some tests need to be added for this? > > Also a correction throughout: dictionnary --> dictionary @Astro-Kirsty, I don't think test are...

Plenary needs lua version 5.1 but disabled on homebrew

Thanks @Conni2461, disabling rocks fixed the issue for me.

introducing union support in ObservationFilter

@registerrier, I think that the logic that I introduce here is not satisfactory. That's why I didn't went further. I need to think about it again. For the GTI, I'm...

No mask in the figure `MapDataset.plot_residuals`

Thanks @bkhelifi, I also notice that ! It is really bothering. It goes without saying that we should to it on `plot_residual_spectral` and `plot_residual_spatial`.

Do we need a container for phasogram ?

Hi @adonath, > This is only partly true. Under the hood the classes work with ND-maps, which can simply contain a phase axis. This is already possibly now, without modification...

Do we need a container for phasogram ?

Thanks @adonath, > I see your point, but the classes are not very different. A light curve is just flux points in time bins, a phase curve is just flux...

Introduce context manager to set energy range to mask fit

Thanks @registerrier, it is a nice feature. However, I think it has to be exposed in tutorials, otherwise it will not be used a lot. Also adding an example in...