MEO265

Results 7 comments of MEO265

I took a closer look at the repo, maybe a PR in master would have been the right thing. What do you prefer @ryapric

Hey @VZoche-Golob , my impression is that the package is no longer being developed. Since I have created a few issues and PRs here myself and have not received any...

Here you can see how base R handles the .Rbuildignore: https://github.com/wch/r-source/blob/1d4f7aa1dac427ea2213d1f7cd7b5c16e896af22/src/library/tools/R/build.R#L85-L87

> Is there a test that can be added? Surely. I'll take care of that too. Just wanted to hear beforehand whether additional functionality would be desired. In order not...

The code is a bit more complex than initially expected, but it should work now

> For example, maybe if `pkgdown/favicon.svg` existed, we could just add it to the `` automatically? What do you think? I think it's a good idea to conditionally include the...

> https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7 suggests that dark mode support for svg requires custom css in the svg, which I suspect few folks will know how to do. Yes, that's true. However, https://realfavicongenerator.net/...