LukeAbby

Cloudflare Captcha Breaking

1

First of all, I understand that this plugin is not currently being actively developed so I really am posting this for if it ever gets picked up again. Second of...

Lint against `.mjs` in imports

1

This is just a minor consistency thing.

Put together a more thorough CONTRIBUTING guide

3

This effectively boils down to the _many_ pitfalls of TypeScript. Common issues seems to be: - Determining the right type for a plain object. Usually `Record`. - Using `InexactPartial` appropriately....

Fix logic for indeterminate nullable/required

1

When `nullable: boolean` users must assume that when _getting_ `null` is a valid option as `nullable` may be true. When setting users must assume `nullable` may be false and therefore...

Core Foundry Documentation Issues (v12)

8

Please use this master issue to document _all_ Core Foundry v12 documentation issues. This will eventually be filed as an issue on the Foundry issue tracker but in the meantime...

Audit all usages of common footgun types like `object`

1

`object` is the wrong type in 99% of cases because it includes all functions and all arrays. It has some limited usage in complex scenarios, mostly to prevent an index...

Make CONFIG more configurable

1

Sub-properties on `CONFIG` aren't very configurable because of limitations in declaration merging. Refactor out all sub-properties that should be configurable into interfaces but keep around the defaults in case there's...

This probably isn't very compatible with Yarn v2's system.

Trace Highlights Unused Types

1

After running "Tracer: tsc trace" I can get warnings on extremely innocuous lines:  Of particular note: ```ts export type ConstructorOf = new ( // eslint-disable-next-line @typescript-eslint/no-explicit-any ...args: any[] )...

We converted files in `src` over to having an `export {}` if there's no `import`/`export` in the file. However our test files don't have that. It's not a huge deal...