Luci
Luci
Hi! @JacksonGL. I just wanted to let you know that memlab is fantastic! But, as you say, it would be easier to use with a UI. So I wonder if...
> @LuciNyan Thanks for your contributions. The internal UI is integrated with Meta infra, so there is no plan to open source the UI in the near future. Can you...
Hi! @JacksonGL. Thanks for the detailed advice! This sounds great! I'm sure memlab will become an even more influential tool!
Are these changes really necessary? 🤔️ I still think that `isNumber(xxx)` is more concise and straightforward compared to `typeof xxx === 'number'`.
> What’s the benefit `isNumber` and `isString` against `typeof`? Concise and straightforward. > 2\. Unneeded function call It looks more concise, so I don't think this is unnecessary. Apart from...
> They don’t look concise, they look like Monkey business code I beg to differ, but don’t mean to knock your coding tastes. It seems pointless to continue the discussion....
Excellent! I really appreciate you taking the time to uncover and resolve this issue.
Hi! @david-buck! Just wanted to let you know that we've rewritten the logic in that section and it looks like your issue has been resolved. Thanks for your detailed report!
> Apologies that it took me a while to come back to this PR, thanks for working on it! I went through it and I agree that this is a...
> @shuding how would you workaround the [limitations](https://harfbuzz.github.io/what-harfbuzz-doesnt-do.html) of Harfbuzz, such as line breaking? Thank you for sharing this!