LucasJavaudin

Results 25 comments of LucasJavaudin

> @LucasJavaudin Could you please review the new unit tests ? Thanks! Yes, this is good!

Can I push to this Draft a test that do not pass but that I think should pass?

> Is it ? IMO the values should always be wrapped in `Value::Union`, so that it is possible to validate it with a Schema. The union items should be: Sorry,...

Consider the following enum: ``` enum MyEnum { Val1, Val2, Val3(u64), } ``` What should be its schema? I can think of two options. ## A record with two fields...

@martin-g Thank you for your work! This solves the issue I raised in [AVRO-3646](https://issues.apache.org/jira/browse/AVRO-3646). I pushed two new integration tests in #1949 that try to deserialize and serialize more complex...

Yes testing this with the EMC2 of Vendée would be great! I forgot to mention that my implementation is based on the Lyon implementation (ADISP). Only few changes are required...

> > This will make the pipeline filter all data sets for the departments noted in the list > > This is intentionally not the case for the HTS (because...

After quickly comparing with the EMC2 implementation of Gironde, I identified that: - The zone shapefile of Gironde would not be correctly detected by this PR (it is expected to...

Sorry, you're going to think that I'm obsessed with it but I'm again going to advocate for polars. 😄 In some cases, converting the DataFrame from pandas to polars just...

Yes that is an option. I think that generating them with no trip can be confusing but this would allow to know which persons have very young child (that can...