Lucas Prates
Lucas Prates
@Gui-FernandesBR I think you forgot to provide the link. Moreover, I could not find the file in google drive.
> Hey, I think we should add a warning in the MonteCarlo initialization saying that the class is still too young and we may change its behavior in eventual future...
While trying to refactor my PR to use the Monte Carlo class, one thing I found missing is to be able to export the trajectories. For the notebook mentioned, this...
Greetings! I failed to reproduce your result. Installing the latest version (1.1.8) of ruptures, the output of the randindex method for the provided lists was $0.9968722559866201$ . I also tested...
> Could you fix it before our review, please? That would help us. @Lucas-Prates Sure, I will fix it briefly. This simplified type hinting started at [python 3.9](https://peps.python.org/pep-0585/#parameters-to-generics-are-available-at-runtime). I will...
The PR is ready for review again. I fixed a bug on the computations of the sensitivity score and it explained why the model was failing overall. Now it works...
@Gui-FernandesBR and @MateusStano, this PR is ready for review again! I believe the review should be somewhat quick. The code has already been thoroughly review, so I recommend focusing on...
Great PR, looking forward to working on it. Before delving into technical details, as I have to read and work on the PR itself, I would like to make a...
Made the suggested changes. The PR is ready for review again!
@emtee14 thank you very much for opening this PR! I have been assigned to help you out with this feature. Your description in #699 and the (nice) implementation here give...