Liam Sarsfield
Liam Sarsfield
I'm going to close this PR in favour of Block Delimiter: Add performance unit test #44811 PR as the new PR leverages the new `Block_Scanner` class instead of the `Block_Delimiter`...
I also agree with having stricter types, though we just encountered an issue that `sprintf-js`'s (https://www.npmjs.com/package/sprintf-js#computed-values) functionality handled, but `@tannin/sprint` didn't. We addressed this here however: https://github.com/Automattic/jetpack/pull/44418, just confirming though...
Hey @anomiex👋 would you mind taking a look at this when you get a chance? This is the performance testing infrastructure I built during HACK week (more details here pc9hqz-3Rb-p2)...
> Yup! Thanks! I scanned the PR but didn't check the existing commands. I wouldn't consider it a blocker for the PR, but it is required to use the fully-leaded...
Hey @Automattic/jetpack-vulcan 👋 I've been working on performance testing infrastructure for Jetpack (measuring wp-admin LCP with Jetpack connected). Part of this involves an mu-plugin that simulates a WordPress.com connection without...
@fgiannar Thanks for the thorough review! > I noticed that you only enable modules that don't require a JP Connection but I wonder if we should enable all of them...