Liam Pattinson

Results 22 comments of Liam Pattinson

Thanks @vinisalazar, I'd be happy to accept any issues/PRs to my lesson and accept new maintainers. I'm already aware of a bunch of issues with the lesson as it stands,...

@brownsarahm That sounds good to me! I usually work on several software engineering projects in parallel, so I won't be able to dedicate myself full-time to this, but I should...

I found the openmc container to be quite difficult to work with. Any change to the Python environment using the setup-python action caused all tests to fail, so simply adding...

I tend to be of the opinion that objects shouldn't know how to plot themselves. The user may have no intention of plotting TokamakSource, but making those methods part of...

Hi Jonathan, for the first point, would I be right in thinking that you're interested in testing that TokamakSource is generating RZ coordinates correctly?

Thanks @RemDelaporteMathurin and @shimwell, that's what I assumed the issue was about. I've managed to get such a test working, though with a few caveats: - It currently only tests...

I've tried looking at an inverse function, but I believe it can only ever be approximate as the a-alpha to RZ relations aren't bijective (at least according to "Tokamak D-T...

I believe so, but the inversion may need to be performed numerically rather than analytically.

Might it be worth including `setup.cfg` and `pyproject.toml`? I'm also wondering if it would be worth rerunning tests when any bash scripts are updated (i.e. changing run_tests.sh could cause CI...

I don't think the proposed solution will work until the release of CadQuery 2.2. Version 2.2 can't be installed from conda yet, and within the master branch the version is...