Liam Goodacre

Results 52 comments of Liam Goodacre

:+1: Can we think of a nice way of having this work in combination with Gists? Possibly make both sources have their own gists and have the PureScript one reference...

Thanks for all the examples. The following would currently work fine for your example @paluh: ```purescript addField ∷ ∀ r1 r2 . RowLacks "field" r1 => Record r1 -> Record...

Anything bad about changing the definition of `intMul` https://github.com/purescript/purescript-prelude/blob/v4.1.0/src/Data/Semiring.js#L10 to be the defaulted polyfill that @hdgarrood posted? ```javascript exports.imul = Math.imul || function(a, b) { var ah = (a >>>...

Ah sorry @hdgarrood, I didn't read your latest comment properly, you already suggested that ^

I guess we would inline from `x * y` to `runFn2 imul x y`? and then delete it when we get better elimination of dictionaries

I've set up a jsperf (https://jsperf.com/imul-or-mul). Unless it's a bad test, I get unexpectedly comparable performance between the following on Chrome: ``` (x * y) | 0 ((x | 0)...

Perhaps a slightly better structure of test? https://jsperf.com/mul-imul-poly-2 But yeah, under the assumption that any of these tests are useful, it seems to me that `imulPolyfill(x | 0, y |...

Possibly worth noting that wrapping `length` in a lamda also makes this start working. ```purescript type Stuff c = { length :: forall a. c a -> Int } foo...

(Short comment as I'm on my phone:) I'm not sure 'wildcard' is an appropriate name. There's also `(_ + 0)`.

Relates to: * https://github.com/purescript/purescript/issues/3067 - Default method implementations * https://github.com/purescript/purescript/issues/361 - Default superclass instances