Louis Gombert
Louis Gombert
I don't really get it, what's the actual benefit of the mach bundle instead of a library? What advantage to we get to use `MODULE` instead of `SHARED` ?
@Arcnor @jcoby has this PR been tested? Can we merge?
> I tested it and it fails on Mac Intel at least. I cannot say if it fails because of it or because of something merged just before it, though...
I very much prefer the toolchain approach! Could you update README instruction about how to use the 32bit toolchain (install i386 packages, and `-DCMAKE_TOOLCHAIN_FILE=...`
@th1000s some conflicts in the workflow file need to be resolved now that unittests have been merged, but it seems good otherwise!
> I think this PR should only focus on adding the tests, not also changing all the types, that should be its own PR. We test the feature that's been...
Unit tests pass locally, they also should on CI. merging
I may have introduced a bug through #920 , I'll test whenever I have the chance. Thanks for reporting this
I took a quick look, you're right, `zCrossProductsSigns` computations have problems (it could be the 0 case). I don't have much time to dig further into it, but I can...
Actually `-setdir` should already solve part of the problem https://github.com/DescentDevelopers/Descent3/wiki/Running-Descent-3#command-line-options