Levi Harrison
Levi Harrison
This version adds use of the `any` type which was only introduced in Go 1.18, causing CI to fail as we're on 1.17
This is probably a separate thing, but I wonder if it would be useful to have a metric that increments for the individual file watch errors: https://github.com/prometheus/prometheus/blob/58ba1d0afaa9186225e6ae90e57c2ec80de097df/discovery/file/file.go#L229
I wouldn't think so. There is a distinction between an error creating a watcher for the entire filesystem and an error watching an individual file - one that is sort...
According to your design doc, the following should work: `rate(prometheus_http_requests_total[0.25])`, but instead I get this error: `Error executing query: 1:37: parse error: strconv.Atoi: parsing "0.25": invalid syntax`. Otherwise seems good!
@boyskila friendly ping :)
I think there are still windows errors happening in the test with this close function: https://github.com/prometheus/prometheus/pull/10321#issuecomment-1053031016, albeit a different error message. I'll try to see if I can figure out...
Ok I finally got my hands on a Windows computer to try out #10321... and I can't reproduce the test error. I think it's something to do with CircleCI, and...
Nice catch, thanks for reporting. I guess the site is either down or doesn't exist anymore?
Don't think your branch matches the `build_all` regex: https://github.com/prometheus/prometheus/blob/d91621890a2ccb3191a6d74812cc1827dd4093bf/.circleci/config.yml#L160
#10902 is closely related to this