Leander Fischer
Leander Fischer
The notebook in [the analysis readme is missing](https://github.com/icecube/pisa/blob/master/pisa/analysis/README.md). A working notebook and/or at least some sentences on how this should be used are needed.
Is it intended that there are multiple (possible duplicate) definitions of the same likelihoods [stats.py](pisa/utils/stats.py), [likelihood_functions.py](pisa/utils/likelihood_functions.py), and [llh_defs](pisa/utils/llh_defs)? Maybe these could be streamlined/combined.
The README in the [pipeline examples](https://github.com/icecube/pisa/tree/master/pisa_examples/resources/settings/pipeline) seems to be super out of date. Maybe someone could clean this up a bit.
In [these lines](https://github.com/icecube/pisa/blob/15eed8557db13638ff241cfbaee8a5ca779f175a/pisa/stages/discr_sys/ultrasurfaces.py#L136-L137), the US fit results are loaded, but this expects an absolute path (so not generic for different clusters/wgs. This could simply be replaced with the [find_resource](https://github.com/icecube/pisa/blob/master/pisa/utils/resources.py#L38) function...
**Describe the bug** The command line interface instructions give a faulty value for `--PatchMatchStereo.geom_consistency` in the `patch_match_stereo` step. In [docu - cli](https://github.com/colmap/colmap/blob/main/doc/cli.rst?plain=1#L68C9-L68C49) and [undistortion.cc](https://github.com/colmap/colmap/blob/main/src/colmap/image/undistortion.cc#L102C27-L102C67) the parameter is set to `true`,...