Simão Martins

Results 111 comments of Simão Martins

`Future.firstCompletedOf` could have an implementation with varargs. Because `Future.firstCompletedOf(f1, f2, f3)` is simpler to read than `Future.firstCompletedOf(Seq(f1, f2, f3))`. Sorry if this is the wrong place to make this suggestion.

Hi @viktorklang In Scala 2.13.0-M4 varargs are now immutable `Seq`s https://github.com/scala/collection-strawman/wiki/FAQ > `scala.Seq[+A]` is now `scala.collection.immutable.Seq[A]` (this also affects varargs methods). So `Future.firstCompletedOf` could be overloaded with a varargs alternative.

Regarding the `logical` keyword, I think its best to not include it for now since issue 1 on the spec clearly defines it as unstable. I don't see the autocomplete...

It would also be helpful to have a method similar to this: `def expectOr[A](uri: Uri)(onError: Response[F] => F[A])(d: EntityDecoder[F, A]): F[A]` Or even: `def expectOr[A](uri: Uri)(onError: PartialFunction[Response[F], F[A]])(d: EntityDecoder[F, A]):...

Should the deprecated methods on "0.21.x" and "0.19.x" be removed from `Client`? Should the overloaded methods receiving `F[Request[F]]`, or `String` be removed? I'm assuming yes, because its a major version,...

> Yeah, that's a hazy area per the above. I'd rather deprecate them, but overloads can diminish the experience. Should we consider deprecating them in 0.21 now, ideally provide a...

In the current implementation `Client` is a decorator around `Request[F] => Resource[F, Response[F]]` which adds some helpful methods to go directly from `Request[F]` to `F[A]`. These methods have some variations:...

Another idea would be to have the level of compromise à lá carte: The base client would be: ```scala trait Client[F] { def run(req: Request[F]): Resource[F, Response[F]] def toHttpApp: HttpApp[F]...

@armanbilge I'm so sorry. I've never re-targeted a PR, and since my commits were on the main branch of my repo (which was out-of-date and not in sync with series/0.23)...