Lance Andersen

> > This looks OK. I did a quick scan and did not see a test in open/test which covers this and it probably would be worth considering adding one...

I was not involved in the original build changes to OpenJDK/Java SE, but this was needed to support some of the platforms openJDK runs on as described in http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html#Common-Predefined-Macros: _LP64...

+1 > On Dec 13, 2019, at 10:07 AM, Christian wrote: > > +1 > > — > You are receiving this because you were mentioned. > Reply to this...

First thank you for your efforts and patience with this PR Archie. I am trying to better grasp the problem to be solved outside of better clarity surrounding how GZIPInputStream...

> > With this new proposed change we will throw an IOException (unlike previously). I think that's fine and in fact the correct thing to do. > > I've run...

> > So where does that leave us: > > Keep the code as is and document the current behavior > > Continue to add additional test coverage for the...

Consider the following simple gzip test ``` gz % cat batman.txt I am batman gz % cat hello.txt hello % cat robin.txt Robin Here gz % cat Joker.txt I am...

> Another (more conservative) possibility is to preserve both 1 ("Trailing garbage is ignored") and 3 ("Concatenated streams are automatically decoded") in the default configuration. > > Then basically all...

Thank you for the contribution Eirik. I will take a peek at this once we are able to push changes for JDK 23

> > I think the change is OK, any reason to not make it `externalFileAttributes`? > > None other than length / verbosity. But since this refers to the _attributes...