Lucas Viana

Results 33 comments of Lucas Viana

@SebastianStehle FYI, I'll work on this.

> IMHO we should discuss the is_alive feature. I have discussed this several times with the team and it is actually a solution to prevent unexpected crashes in .NET because...

Hi, @SebastianStehle! Did you have a chance to continue reviewing this PR? I assume you're not finished since there are just a couple of comments and I pushed a lot...

Regarding this: > I would ... > > 1. Create a struct for ybranch_id, so we can distinguish it from actual pointers. Mark this internal. > 2. Always store brand...

Okay, this makes sense but I don't see how to reflect this in the code properly. If you have the time, please feel free to push commits here to show...

@SebastianStehle I'm not sure I understand the latest changes. If we turn the `public class BranchId` into `internal record struct`, we can probably just drop it and use the `BranchIdNative`...

> Perhaps we should focus on the breaking changes first without the ID stuff and then add them in a later reelase. I don't have a strong opinion here, I'm...

@SebastianStehle Got it! I understand it better now. I pushed three commits now that I'd like you to review. If you agree with the changes, we can propagate them to...

@SebastianStehle Just mentioning you again to double-check if you had a chance to check my previous message.

@SebastianStehle That's great! Given that, I propagated those changes to all other `Branch` types. Can you check these latest changes in the classes of the `YDotNet` project, please?