Serhiy Yaroshko

Comment to chapter "Reuse and composition at work"

1

p. 61 Bug in the code: “WidgetClassListPresenter >> initializePresenters list := self newList. list items: (**AbstractWidgetModel** allSubclasses sorted: [:a :b | a name < b name ]). self focusOrder add:...

p. 178 “TodoTask class >> tasks ^ tasks ifNil: [ tasks := **OrderedCollection** new ]” – why an OrderedCollection? Why not a **Set**? The method _TodoTask class >> addTask: aTask_...

p. 172 Typos “If you want to use your values you have to pass them before initialize is called **y** several ways for **that**” – should be “If you want...

p. 151 - Typo in the text “Using such helper methods we defined the method _hasSelect**Contract**_ as follows” – should be _hasSelectContact_. - Bugs in the code “**CmAddContactCommand** >> initialize,...

p. 141 “EgContactBook >> add: contactName phone: phone | contact | contact := EgContact **new name: contactName; phone: phone**.” – should be “_EgContact name: contactName phone: phone_.” with help of...

p. 134 “Our actual Athens code is located into renderAthens **method:**, _and the result is stored in the surface instance variable_.” – the colon should be removed; the second part...

p. 119 “and then build a little **editor**”, p. 127 “Defining a presenter for the **Editor**” – is it really an editor after “_text beNotEditable_”? The created application is at...

p. 107 “For example, let me show you the following code snippet:” – it would be very nice to explain that these snippets can be executed in a _Playground_. p....

p. 97 “not forcing you to declare upfront sub presenters in instance **variable**” – variables should be in the plural form p. 99 Code snippet “add: button2 withConstraints: [ :constraints...

p. 89 SpPresenter