LJ

Results 26 comments of LJ

The goal was to make L2186 consistent with the zlib parsing error above. I would say making those "both do the same thing" as you put it makes more sense...

> Did we figure out the performance impact of this? Ran a quick test and it seems like the impact is around ~30% for just the parsing code. Doesn't seem...

Wait what how do USBs play into anything.

I spent maybe 30 minutes trying to create a bare-bones repro and was entirely unable to. I don't have time to look into it in more detail, and this is...

I noticed the kelp and water appear to render incorrectly with many blocks, not just glass. This was on version 0.3.2+build.7 ![image](https://user-images.githubusercontent.com/23249107/138038141-0e0c2bed-4565-4c8a-b761-bdfa1d641cf5.png) ![image](https://user-images.githubusercontent.com/23249107/138038192-22cfd2dc-cfcc-4c0e-bcd3-329145e0f47f.png) ![image](https://user-images.githubusercontent.com/23249107/138038328-1af4c381-2865-4300-84f2-143c64deb494.png)

Also, all one-block tall ice appears to not render any submerged parts. ![image](https://user-images.githubusercontent.com/23249107/138038671-9ada4a4f-81a5-49c8-ab45-2994d6d71d6c.png)

If this helps diagnose the issue: I haven't opened VSCode on that computer in months. The local index versions appear to be from around when I last opened VSCode.

I'm still getting data racing (on 3.6 with rocksdb) with a simple update request, `collection.update("key", {data}, {keepNull: false})`. Although it's error code 412 not 409.

I would be happy to open a pull request but wish to confirm interest from the maintainers first.