Kyle Siefring
Kyle Siefring
Mostly want it hidden so that I can add and remove it without multiple api changes. I felt that using pub(crate) might end up being too error prone. Example: accidentally...
FYI, this doesn't seem super substantial when profiling.
This is what I get when running these commits. Unfortunately, it seems to give a loss. That doesn't necessarily mean that this shouldn't be commited. https://beta.arewecompressedyet.com/?job=ref_near_mv_global_mv_s6%402020-06-01T17%3A17%3A56.780Z&job=fix_near_mv_global_mv_s6_correct%402020-06-01T17%3A43%3A10.635Z https://beta.arewecompressedyet.com/?job=ref_near_mv_global_mv_s3%402020-06-01T16%3A52%3A53.098Z&job=fix_near_mv_global_mv_s3%402020-06-01T16%3A43%3A45.501Z
Actually, I'm not sure my touch command is working... EDIT: nvm, it works
I think this is only triggered when tx_domain_rate is true. It never is. If I turn it on, I get a segfault with my patch. Looking at the commit that...
I'm confused. Isn't this already optimized from the assembly called from here? https://github.com/xiph/rav1e/blob/master/src/asm/x86/cdef.rs#L195
https://github.com/xiph/rav1e/blob/master/src/rdo.rs#L1454 I believe best_cost[pli] will be < 0 if cdef is disabled. This would cause sgr to always be used.
I consent to re-license my contributions to build.rs.
The loop in rdo_loop_decision iterates until both cdef or lrf have stopped changing. Are you sure cdef isn't changing as well?
`diamond_me_search` passes `use_satd` to `get_mv_rd_cost` and `use_satd` is also determined by a runtime option.