Kyle Bastien

Results 11 comments of Kyle Bastien

Note: As a workaround... I was able to use these types based on the types from Apollo: ``` import { ApolloQueryResult, FetchMoreOptions, FetchMoreQueryOptions } from 'apollo-client'; import { DocumentNode }...

All of these changes seem like good next steps for FlipClock and I'm looking forward to seeing them be implemented. As you get closer to the point in time where...

I'm going to say both. I think if people find the project via the GitHub repo will want to be able to show off different clock face themes in the...

I don't think we should just limit to having the user only pass in the ValueType, I think that's very limiting for possible future scenarios where a user can pass...

Also I am not sure that `Dictionary` would be the right choice as the type name here, I think given the limitations of Strings or String derivates only as the...

But what (if in the future) you had other String derivate types other than Enums? For example, String Literals come to mind. How then would you express the String Literal...

> In that case, isn't it equivalent to this? I'm not sure how you would access a key in your example based on the enum key. For example, how would...

Just to add to this, since the release of [Scalars](https://concerto.accordproject.org/docs/specification/model-scalars) in the Concerto language I think this increases the need for a Record type to be able to specify both...

> We should choose one of the following variants. At least to me I think the "Modifers" syntax looks a little confusing just because I would expect that to be...

@mttrbrts thanks for putting that together. I think what you have in that spec generally looks good to me. A few pieces of feedback: > The other property indicates the...