Krisztiaan

Results 10 comments of Krisztiaan

These are very vague rules. It would be sufficient, if the jCenter library just contained the Orientations.java. I imported just that file in the project, and it works without any...

One workaround for now, would be adding the Orientation.java to your project yourself, to the correct package.

> @Krisztiaan thanks for doing this. > I will let @jennmueng and @AbhiPrasad review this since they own the JS know-how. No problems, this is very close to what I...

Thanks, I'll do a little bit of PR housekeeping this weekend.

@marandaneto the change is done, also saw a place to bring in `normalize` :)

@marandaneto tests are failing with `walk`, due to different parsing logic than what's expected here. (`serializeValue`) Pushed so you can see the fail cases too. Advise on how you'd want...

Do let me know what's up. Imo this could be somewhat important to deal with in a timely manner, as it can cause unexpected crashes, related to a crash detection...

This is not a `react-navigation` only issue. Pass a circular object to any of these calls, or just try the added tests from this PR without the functional modifications of...

> FYI: this was merged into the TS main branch and then reverted because it can cause filter to convert any[] to unknown[] - which is not a issue for...

Not sure how relevant that is, but even if passed `imgSizes` in query, it seems to be [straight up ignored](https://github.com/sveltejs/kit/blob/main/packages/enhanced-img/src/index.js#L108-117) in `enhanced:img`