Kris Thielemans

Results 966 comments of Kris Thielemans

presumably run `nbstripout` on the file first?

Sadly I have no time to investigate this further. Sorry. From what I recall, there actually are no conflicts (after applying the filter) in the use case given above. Maybe...

#985 reorganised things, which is good, but did not fix the actual `pytest` failure, so re-opening. See there for more comments. #985 disabled the `pytest` on MacOS until someone comes...

Looks like we check modality to determine if we should write a SPECT Interfile header: https://github.com/UCL/STIR/blob/07aad4371043136f6d2f0ee63893cfabb6e5104b/src/IO/interfile.cxx#L1191 This implies that the modality info is wrong. I do notice that in general...

ah well. Luckily, this seems to be a private variable in both cases, so I think we can adjust this without affecting anyone. We'll also need to fix doxygen strings...

@NikEfth, did you run the recon_test_pack locally? Travis throws up a lot of problems in it. For instance core dumps in the ROOT tests, but also others. it's always difficult...

current Travis failures ``` The command "./run_test_listmode_recon.sh" exited with 1. The command "./run_test_zoom_image.sh" exited with 1. ${PYTHON} -m pytest . collecting 0 items / 1 errors/home/travis/.travis/functions: line 109: 18344 Segmentation...

`run_test_listmode_recon.sh` and the Python test are currently failing

@ALEXJAZZ008008 @NikEfth in my previous commit, I changed `ProjData::get_num_sinograms()` to include the num-TOF-bins. I did this because we call a `Sinogram` as 2D array. It also meant that `size_all()` could...

oh, maybe the Python test does check it, as I see my comment above that it's failing... Also, listmode recon...