Kory Nunn

Results 31 comments of Kory Nunn

After further testingI'm almost certain the issue is due to the following fix not being released to version 8.X of the sdk: https://github.com/firebase/firebase-js-sdk/blob/46fe1362cf9eaac216d4a7bbdc234f472567aa44/packages/firestore/src/local/indexeddb_persistence.ts#L980 If i make that change manually in...

Additionally, WKWebView does not report with an appVersion that includes "Version", at least in Cordova, so this check will continue to fail.

We cannot trivially update to v9 due to how v9 automatically decideds what environment it is running in. This issue will not exist in v9 because the fix has already...

@dconeybe firebase internally looks for things like `window` or `process` on global scope, and decideds that it is running in a browser or node. Our integration tests run in node,...

In our test code that runs in node we: 1. Add a `window` property to global, that looks legit (jsdom instance) 2. Delete the following from firebase: ``` delete firebaseInstance.INTERNAL.node;...

Clone works fine without Buffer, it checks for its existence here: https://github.com/pvorb/node-clone/blob/51a79bbb0b1b781503cf2497ab1ea083bfaba49f/clone.js#L35 Making it a flag per project is a really bad idea, because you never know if/when an npm...

I guess this could be assumed by browserify by hunting for `typeof Buffer`, which would remove the requirement for explicit control, and remove the requirement for plugins, but I'm a...

Nice, works well in the meantime, thanks @zertosh

Updated to check window instead, but really I'd rather the pr wasn't required at all. This is exactly why a package.json flag would be handy.

See here: https://github.com/pvorb/node-clone/pull/46#issuecomment-98929649 using noParse: ['clone'] does prevent the module from using `Buffer`s, since browserify won't add it to the modules wrapping function parameters. however, were there a flag to...