Zhang Zhanpeng
Zhang Zhanpeng
This Issue/PR is under discussion and is just an example.
> Best to see by adding test cases (or observing which existing tests change their result in which way), which should mostly affect the framework tests in https://github.com/prometheus/prometheus/tree/main/promql/testdata . I...
Yes. According to my observation, these problems occur **randomly** when merging parts: ``` panic: FATAL: unrecoverable error when merging parts in the partition ("/victoria-metrics-data/data/small/2024_01", "/victoria-metrics-data/data/big/2024_01"): cannot merge 14 parts to...
Thanks Reply. > Hello, this check protects from possible on-disk data corruption. Are there other instances of this situation? **A1:** Yes. VictoriaMetrics runs in a Docker container and the data...
> @KofClubs , could you build VictoriaMetrics from the commit https://github.com/VictoriaMetrics/VictoriaMetrics/commit/9c9021fd8b3c95d885c465bbfbe7410aaaf6a70e and verify whether it leads to the FATAL: unrecoverable error when merging parts in the partition panic? I created...
> In the meantime, @KofClubs could you fix the DCO? It should be easy. See the details of the failed DCO test. OK. I shall fixup all commits to one...
With conflicts resolved and commits signed off, I think this PR is ready to be reviewed:)
> About the lookback delta: Get it. I think there are some aspects worth exploring. #### Motivation Apart from making behavior consistent, are there any other motivations for making lookback...
> WDYT? Both OK. While, I think this change has a large impact. Considering the change in user habits and behaviors, adding a flag seems to be necessary. I think...
> I unresolved two conversation above where you went into the opposite direction than intended. Thanks. Both resolved. Review them please:)