KiterLuc

Results 46 comments of KiterLuc

@ihnorton Added a check for adding the same value twice. For this question: - do we need an API on query to get these values back out? We currently don't...

A couple things. From a performance standpoint, this looks equivalent from a first glance to the current implementation but just to make sure, we should run a couple customer scenarios....

A couple things. From a performance standpoint, this looks equivalent from a first glance to the current implementation but just to make sure, we should run a couple customer scenarios....

Hi Vincent, Thanks for the feedback. This fix (https://github.com/TileDB-Inc/TileDB/pull/3323) that reduces the class A calls to a bare minimum will be included in the next release (2.11) scheduled for 27...

> LGTM to merge as experimental. We still need to address the semantics question regarding whether we need a separate update query type ([SC-20964](https://app.shortcut.com/tiledb-inc/story/20964)) before moving out of experimental. Agreed...

Closing since we plan to implement this a different way in 2.19.

This should be fixed. Please re-open if it's not the case.

@teo-tsirpanis let's not work more on this PR. I started to review and it became obvious to me we need to design something different here. The 30 parameters constructor doesn't...

> I restored some move constructors and am getting [errors like](https://github.com/TileDB-Inc/TileDB/actions/runs/8730023907/job/23953067632?pr=4682#step:14:292) `static_assert failed: 'T must be constructible from either (allocator_arg_t, const Alloc&, Types...) or (Types..., const Alloc&) if uses_allocator_v is...