Kiran Panesar comments

Results 10 comments of


                                            Kiran Panesar

Added a Completion Handler, removed 'AppDelegate' dependency, added a better gitignore

@romaonthego Any update here?

Small fixes that the Xcode Analyzer brought up.

Hey Anlumo, can you fix the merge conflicts here, then I'll take a look and merge it in.

checkDate in MXLCalendarEvent

So if the current date/time is 1PM on June 10th and the event is 10AM on June 11th, `checkDate` would return TRUE?

checkDate in MXLCalendarEvent

Thanks for reporting this! @Jaikant Did you say that you'd already implemented a solution? If so, could you submit a pull request with your changes?

Cocoapods support

Awesome! :facepunch:

Didn't work for me

:+1: Seeing this too. Even when I use buttons and set a delegate…

Didn't work for me

Got it to work by making it a `strong` property.

Fixed white flicker when loading ReaderViewController

Hmm, now the flicker is even more obvious on a light background. It looks like the PDF doc is flashing black before showing. Any ideas?

Fixed white flicker when loading ReaderViewController

It looks like it's happening when creating the ReaderViewController as a subview of another view. Try the second example in the demo project.

Fix locales + add strings in bundle

Hi @etabard. Thanks for the PR! Sorry it's taken me over 6 months to get to it! Can you merge master back into yours and submit again. I'll gladly review...