Keith Yeung

Results 147 comments of Keith Yeung

With #193 merged, we have extended InferenceTable to contain a method named next_subgoal_index, but still haven't figured the specifics of which goal to prioritize/deprioritize.

@robsecord I just realized that the current `ChargedParticlesERC1155` contract on master does not implement `IChargedParticlesERC1155`, is that intended? EDIT: Same question for `ChargedParticlesEscrow` and `IChargedParticlesEscrow`.

Update: In the ChargedParticles contract, the majority of the Admin/DAO functions and all of the public read functions for an ion token have unit tests with then, right now I'm...

@robsecord I noticed one thing -- the `withdrawFees` function does not set the `collectedFees` for that particular `_contractOwner` back to 0. Is this intended, or is it a bug?

@robsecord I'm still going to write some more unit tests, the last one there was just partially done so that you may be unblocked on other tasks that you may...

@robsecord Sorry, the `withdrawFees` function in `ChargedParticles.sol` is still not resetting the associated `collectedFees` back to 0. In the unit tests, it is still impossible to repeatedly withdraw fees indefinitely,...

@robsecord Hey, sorry I dropped the ball on this one. I had to deal with some personal issues and this slipped my mind. I have a small enhancement on the...

Does this issue also include unifying the exception types with the existing types? It is totally valid Ruby code to raise an exception as a "return value", e.g. ```ruby def...

I'm a bit hesitant to add an API that allows any signed account to simply provide an encoded call and then have it be executed on a foreign chain. It...

What I would argue instead is whether you can think of a way to introduce a new XCM instruction that sidesteps this issue. Remember, _any_ XCM instruction is capable of...