Ke Wang
Ke Wang
I also have the same problem Modifying `ImgCache.cacheFile` to the following has solved the problem for me (tested on Android): ``` javascript ImgCache.cacheFile = function (img_src, success_callback, error_callback, on_progress) {...
@Lionad-Morotar 真巧，两周前写了一个PoC式的浏览器插件，后端ElasticSearch，现在还算可以用（最基础的高亮、笔记功能），有兴趣一起搞吗 https://github.com/kevinwang15/breeze
可能是序列化方式的问题 web-highlighter序列化高亮是基于DOM路径的，当被标记网页发生变化时高亮的反序列化会错乱。另一种序列化方式是记录高亮文本和高亮文本前、后N个字符，这种序列化方式不依赖DOM路径，网页内容发生变化时可以正确反序列化。事实上我在做Chrome插件的时候也遇到了这个问题，然后调研了业界成熟的闭源Chrome插件如diigo、weava，发现他们用的都是后面一种方式。我后来自己做了一个后面一种方式的实现：[notelix/web-marker](https://github.com/notelix/web-marker)
Hi @ishan16696 , I have rebased this PR
Hi @sibucan, I have addressed these problems, PTAL again, thanks.
> Can you fix this and you can also Locally test this by running make check. Okay, I will. > or if --encryption-config-path is optional then it itself can act...
I have updated the code, PTAL again
@ishan16696 Right, I guess changing encryption config on the fly isn't really practical. I can update the code to only read encryption config once at start, to avoid the confusion....
My use case didn't involve rotating the key so I didn't think about it as much as you did. 😃 I understand your points. There's no conclusion yet? Maybe we...
Yes, I agree. Take your time, there's no hurry merging this PR