Nathan Gauër comments

Results 72 comments of


                                            Nathan Gauër

Criterion hangs - cannot define global max timeout (2.3.3 & 2.3.2)

Mmm, core/runner_coroutine.c:337 -> if timeout is set to 0 by the test, the timeout option is unused. And default timeout might be 0 (not checked yet).

Criterion hangs - cannot define global max timeout (2.3.3 & 2.3.2)

A simple one could be: ```C Test(Core, feature_a) { for(;;) continue; } ``` Yes but do I want to kill the whole test-suit for 1 failing test ? Plus, I...

`-fcolor-diagnostics` fails with GCC when building llvm-tblgen

Hello all! Saw this one as a quick fix. Found more occurrences in tools/clang, but unsure if we open edits on this subtree (doesn't look to be a submodule).

`-fcolor-diagnostics` fails with GCC when building llvm-tblgen

Yes that is correct, my bad! Initial comment mentions it happened "after I ran CMake manually inside its cache folder." Maybe was ran on a subset of the files or...

[SPIR-V] ShaderViewportIndexLayerEXT is now Core 1.2

Hello! I can reproduce this one, I'll take a look into it 🙂

[SPIR-V] ShaderViewportIndexLayerEXT is now Core 1.2

Hello! Update on this: found the reason: DXC doesn't check the SPV version and requests the extension all the time. Fix seemed trivial, but now DXC just drops the generated...

[SPIR-V] fatal error: generated SPIR-V is invalid: The <id> passed to OpAccessChain to index into a structure must be an OpConstant

Hello all! Can reproduce at 7a45cbbf8bab340d212d72c3cfe9f8c5f5837ccf on linux. Will investigate.

[SPIR-V] fatal error: generated SPIR-V is invalid: The <id> passed to OpAccessChain to index into a structure must be an OpConstant

This issue is caused by SPIRV-Tools optimizer. Root cause found and fix found. However I need to solve another bug before being able to submit this fix.

Access violation on variable with initializer if type is qualified

Thanks for the report 🙂 Steps to reproduce: ``` ./dxc -T cs_6_0 repro.hlsl ``` With the content of the given code in repro.hlsl. Without the full qualification, the compilation fails...

[SPIR-V] Verify behavior of GetAttributeAtVertex

This is now fixed (https://github.com/microsoft/DirectXShaderCompiler/commit/27b87b75937f4d3fff0c486bc9bba6540c3bddb7)