Karman Singh
Karman Singh
is this issue still open? can i look into this?
@kinto0 , i will work on your suggestions but can you please tell what are the merge conflicts and how do i go about fixing that. it would be great...
hi i think i made some mistake while trying to resolve the conflict, but it seems fine to me now. sorry for the mess of commits i made, still new...
only changing the test is left you can tell me if you want the previous test, i will add that tonight rest changes i have made you can take a...
hi, sorry for the delay i have reverted the test to the previous test. you can look and tell me if there is any issues
@kinto0 is there any update?
@kinto0 is there any update
@kinto0 i am sorry i accidentally closed this pr, i am still figuring out git github. i request you to reopen this sorry for the inconvenience
@kinto0 i have redid the issue and test file please check and sorry for the problems before still new to this. thanks for your cooperation.
hi, so i made a pr for this issue pr #1666 which fixed it and also added a test case for verification