kassa_

Results 6 comments of kassa_

What is the main entry point for execution? `Main` or `Run`?

In my opinion, I think the entry point should be either `main` like 90% of the languages or "no function at all" like NodeJS or C#. It could be specified...

Add the possibility to add response header on WebSocket handshake request

I'm missing the "Sec-WebSocket-Protocol" header. I've tried editing the code of the latest release version with the "onhandshake" callback and it works pretty well.

Add the possibility to add response header on WebSocket handshake request

You're right ! I can add something like that just for "Sec-WebSocket-Protocol" then. Like a hook on the WebSocketRule that takes a list of strings, check that in the Connection...

#692 Add the possibility to specify "Sec-WebSocket-Protocol"

I rewrote find_first_of algorithm and put it in utility.h :)

#692 Add the possibility to specify "Sec-WebSocket-Protocol"

Currently, the "subprotocol_" is only a private variable and is only used in the [Connection::start](https://github.com/CrowCpp/Crow/compare/master...KaSSaaaa:Crow:ws-subprotocols#diff-e16d65f62049168bfc9ebf5932b667ce174bb53215a6e48c8d4c46b4ae113d5aR287-R292) but I can add a getter in the interface and implementation if it's needed.

#692 Add the possibility to specify "Sec-WebSocket-Protocol"

Apparently missed the include of for utility::find_first_of ...