VAL icon indicating copy to clipboard operation
VAL copied to clipboard

Default espislon to 0.001 instead of 0.01 in Validate to be consistent with POPF ?

Open gbesancon-schlumberger opened this issue 6 years ago • 2 comments

Change the default epsilon value from 0.01 to 0.001 Validate to be consistent with POPF ?

gbesancon-schlumberger avatar Aug 05 '19 13:08 gbesancon-schlumberger

I prefer to leave this as 0.01 for legacy consistency. Users should be aware that it needs to be set for validation of a plan in specific contexts.

DerekLong101 avatar Aug 08 '19 09:08 DerekLong101

Suggestion: when the plan is found invalid for a temporal consistency reason, the -t suggestion is printed as part of the output. The smallest time increment in the plan could also be used to determine whether epsilon is set correctly. E.g. we observe the time increments in this plan are as small as 0.001, consider using the -t switch to set the same epsilon time step that was used by the planner that created this plan.

jan-dolejsi avatar Aug 20 '19 14:08 jan-dolejsi